Add masking debug overlay #4357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a1ad9eb | 410.17 ms | 447.29 ms | 37.12 ms |
| 3334b5a | 415.90 ms | 436.16 ms | 20.26 ms |
| a08f05e | 436.23 ms | 466.02 ms | 29.79 ms |
| 6e73020 | 425.81 ms | 493.12 ms | 67.31 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a1ad9eb | 1.58 MiB | 2.08 MiB | 510.65 KiB |
| 3334b5a | 1.58 MiB | 2.08 MiB | 510.82 KiB |
| a08f05e | 1.58 MiB | 2.08 MiB | 510.82 KiB |
| 6e73020 | 1.58 MiB | 2.08 MiB | 507.64 KiB |
romtsn
reviewed
Apr 25, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/util/DebugOverlayDrawable.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Apr 25, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/util/DebugOverlayDrawable.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Apr 25, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/util/DebugOverlayDrawable.kt
Outdated
Show resolved
Hide resolved
Yeah so I talked to @krystofwoldrich yesterday, and turns out iOS also has a similar option - we were thinking of introducing a top-level api like |
|
Cocoa has Related cocoa PRs: |
alright, couldn't we draw stroke rectangles instead of solid? then we wouldn't need the opacity parameter. Just trying to align I guess |
romtsn
reviewed
May 16, 2025
sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MainActivity.java
Outdated
Show resolved
Hide resolved
romtsn
reviewed
May 16, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/util/DebugOverlayDrawable.kt
Show resolved
Hide resolved
romtsn
reviewed
May 16, 2025
romtsn
reviewed
May 16, 2025
romtsn
reviewed
May 19, 2025
romtsn
approved these changes
May 19, 2025
rbro112
pushed a commit
that referenced
this pull request
May 20, 2025
* Add masking debug overlay * Improve contrast for debug mode * Improve readability * Add ReplayIntegration.enableDebugMasking API, improve debug overlay * Update Changelog * Introduce IReplayApi * Update Changelog * Fix Sample app * Move replay API from SentryAndroid to Sentry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Masks, revealed
For debugging purposes
Screen_recording_20250516_111258.mp4
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps