Allow the usage of JSON for Elixir 1.18+ #845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks for applying the changes! The CI is failing for Elixir 1.18+. Maybe |
solnic
reviewed
Jan 3, 2025
| assert error.__struct__ == JSON.DecodeError | ||
| else | ||
| assert error.__struct__ == Jason.DecodeError | ||
| end |
There was a problem hiding this comment.
Given that we're introducing a shim under Sentry.JSON shouldn't we also raise Sentry.JSON.DecodeError?
There was a problem hiding this comment.
We're not introducing Sentry.JSON for users, it's just for us during this transition time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@altjohndev I couldn't force push to your branch, but this is your PR with some changes I made on top of it to remove the compile-time configuration and other small cleanups. Can you review this? 🙃