[timfish]

Fixes #1477

On Windows, before-quit and will-quit are not emitted on system shutdown, restart or user logoff. app.exit() skips both events on all platforms. In these cases the main process session stayed ok on disk, and the next start reported it as abnormal. Long-running tray apps got an abnormal session after every reboot.

Changes

• On Windows, listen for the session-end event on every BrowserWindow. When it fires, write the session to disk as exited.
• Wrap app.exit() so that it writes the session to disk as exited before the app exits.
• The write is synchronous (new Store.setSync()), because Windows can end the process soon after session-end and async work may not finish.
• The session is not ended in memory. If the app still exits through will-quit, the normal path sends the session and clears the file, so it is not sent twice.
• On the next start, a persisted exited session is sent with its original end time and duration. If a minidump from the previous run is found, the session is still reported as crashed.
• previousSessionWasAbnormal() now calls checkPreviousSession(false) instead of duplicating its code.

Behaviour change: process.exit()

From Electron 43, process.exit() in the main process calls app.exit(). Because of this, a session that ends with process.exit() is now reported as exited on Electron 43 and later. On older Electron versions it is still reported as abnormal.

The abnormal-exit and abnormal-exit-electron-uploader e2e tests used process.exit() to simulate an abnormal exit, so they now kill the app with SIGKILL. This gives a real abnormal exit on all Electron versions.

Limitations

• Windows apps with no open window still get abnormal after a shutdown, because session-end is a BrowserWindow event and Electron has no app-level equivalent on Windows.
• The session-end path is not covered by an automated test, because it needs a real Windows logoff or shutdown.

Tests

• New e2e test sessions/app-exit: the first run exits with app.exit(), and the second run must send that session as exited. It fails on master with abnormal.

---

Generated by Claude Code

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 6d9acee. Configure here.}