-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs(react): add Metrics to Next Steps section #16197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # PR Description Format | ||
|
|
||
| When creating pull requests for sentry-docs, use the following format: | ||
|
|
||
| ```markdown | ||
| ## DESCRIBE YOUR PR | ||
|
|
||
| [Clear description of what the PR does and why] | ||
|
|
||
| [Bullet points of specific changes if helpful] | ||
|
|
||
| - Change 1 | ||
| - Change 2 | ||
|
|
||
| ## IS YOUR CHANGE URGENT? | ||
|
|
||
| Help us prioritize incoming PRs by letting us know when the change needs to go live. | ||
| - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> | ||
| - [ ] Other deadline: <!-- ENTER DATE HERE --> | ||
| - [x] None: Not urgent, can wait up to 1 week+ | ||
|
|
||
| ## SLA | ||
|
|
||
| - Teamwork makes the dream work, so please add a reviewer to your PRs. | ||
| - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. | ||
| Thanks in advance for your help! | ||
|
|
||
| ## PRE-MERGE CHECKLIST | ||
|
|
||
| *Make sure you've checked the following before merging your changes:* | ||
|
|
||
| - [ ] Checked Vercel preview for correctness, including links | ||
| - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) | ||
| - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) | ||
| ``` | ||
|
|
||
| ## Notes | ||
|
|
||
| - Default urgency to "None" unless the user specifies otherwise | ||
| - Include preview URLs when relevant (Vercel deploys preview URLs automatically) | ||
| - Keep the "DESCRIBE YOUR PR" section concise but informative | ||
| - Use bullet points for multiple discrete changes | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, but was it intended to be a part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, I probably should have broken it out. I forgot I was on this branch when I made this addition. If it looks okay, I'll just merge. 😄