-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Android new User Feedback instructions #13758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added new User Feedback Widget configuration options
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 2.93kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
| ### Form Labels Configuration | ||
|
|
||
| You can customize tha labels and placeholders used in the form. | ||
| Note: manifest options are not supported here, due to internationalization: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the note should be an <Alert>, up to you
| | Hook | Type | Description | | ||
| | ----------------- | ------------------------- | ------------------------------------------------------------------------ | | ||
| | `onFormOpen` | `() -> Void` | Called when the feedback form is opened. | | ||
| | `onFormClose` | `() -> Void` | Called when the feedback form is closed. | | ||
| | `onSubmitSuccess` | `(Feedback) -> Void` | Called when feedback is successfully submitted via the prepared form. | | ||
| | `onSubmitError` | `(Feedback) -> Void` | Called when there is an error submitting feedback via the prepared form. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the tables 👍
we should use those more often in docs where it makes sense 🤔
coolguyzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding!
Co-authored-by: Alex Krawiec <[email protected]>
added associatedEventId in sample code snippets updated java/android sdk-api-example
…' into stefanosiano/android-user-widget
|
|
||
| ### Session Replay | ||
|
|
||
| The User Feedback widget integrates seamlessly with Session Replay. When the widget is opened, the SDK buffers up to 30 seconds of the user's session. If feedback is submitted, this replay is sent along with the feedback, allowing you to view both the feedback and the user's actions leading up to the feedback submission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The User Feedback widget integrates seamlessly with Session Replay. When the widget is opened, the SDK buffers up to 30 seconds of the user's session. If feedback is submitted, this replay is sent along with the feedback, allowing you to view both the feedback and the user's actions leading up to the feedback submission. | |
| The User Feedback widget integrates seamlessly with Session Replay. The SDK buffers up to 30 seconds of the user's session; if feedback is submitted, this replay is sent along with the feedback, allowing you to view both the feedback and the user's actions leading up to the feedback submission. |
I think it's a bit misleading, the SDK buffers replay even without the widget being opened
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, but if the widget is opened, a replay is captured, and then it's not captured again when the feedback is sent.
But that's technical details, so i'm fine to simplify the wording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so wait, we capture replay just by opening the widget? What if user just closes it without sending anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that case we send the replay anyway. Should i change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 do we do this across all platforms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clarified with the others. We send the replay regardless of the feedback being sent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jumping in here after a discussion in Slack: We are not doing it yet for Cocoa.
See this issue: getsentry/sentry-cocoa#5425
added new Android User Feedback API instructions and widget configuration options
added new Android User Feedback API instructions and widget configuration options
DESCRIBE YOUR PR
added new User Feedback API instructions
added new User Feedback Widget configuration options
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES