Skip to content

Only enable load debug image integration for obfuscated apps #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

buenaflor
Copy link
Contributor

📜 Description

Only enable the debug image integrations for obfuscated apps.

This will also allow us to track obfuscated vs non-obfuscated apps

💡 Motivation and Context

Closes #2891

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Sorry, something went wrong.

buenaflor added 2 commits May 5, 2025 15:31
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.58%. Comparing base (5002a1f) to head (1ade42f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2907   +/-   ##
=======================================
  Coverage   87.57%   87.58%           
=======================================
  Files         280      280           
  Lines        9201     9208    +7     
=======================================
+ Hits         8058     8065    +7     
  Misses       1143     1143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buenaflor buenaflor requested a review from denrase May 5, 2025 15:29
@buenaflor buenaflor marked this pull request as ready for review May 6, 2025 09:19
@buenaflor buenaflor marked this pull request as draft May 7, 2025 11:57
buenaflor and others added 21 commits May 7, 2025 14:27
@denrase denrase changed the base branch from main to feat-web/debug-id May 26, 2025 09:58
@denrase denrase marked this pull request as ready for review May 26, 2025 10:01
Copy link
Contributor Author

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buenaflor and others added 14 commits June 12, 2025 11:40
…-integration-for-obfuscated-apps
…-integration-for-obfuscated-apps
Base automatically changed from feat-web/debug-id to main June 20, 2025 10:57
buenaflor and others added 3 commits June 20, 2025 13:26
…for-obfuscated-apps
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1259.31 ms 1268.79 ms 9.48 ms
Size 7.85 MiB 9.44 MiB 1.59 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
99704d2 1241.74 ms 1258.00 ms 16.26 ms
1cc9547 1230.81 ms 1260.79 ms 29.98 ms
1ac008b 1223.96 ms 1247.77 ms 23.81 ms
873fb42 1261.00 ms 1285.92 ms 24.92 ms
ecb4003 1266.94 ms 1290.24 ms 23.31 ms
c328ffc 1236.73 ms 1260.73 ms 24.00 ms
8ced2dc 1258.35 ms 1272.98 ms 14.62 ms
7b2e0ad 1246.92 ms 1275.22 ms 28.31 ms
bc82442 1239.13 ms 1247.77 ms 8.64 ms
50bdfad 1253.14 ms 1274.54 ms 21.40 ms

App size

Revision Plain With Sentry Diff
99704d2 8.42 MiB 9.87 MiB 1.44 MiB
1cc9547 8.42 MiB 9.86 MiB 1.44 MiB
1ac008b 8.32 MiB 9.38 MiB 1.06 MiB
873fb42 8.16 MiB 9.17 MiB 1.01 MiB
ecb4003 8.09 MiB 9.07 MiB 1000.82 KiB
c328ffc 8.34 MiB 9.67 MiB 1.33 MiB
8ced2dc 8.10 MiB 9.16 MiB 1.07 MiB
7b2e0ad 8.38 MiB 9.73 MiB 1.35 MiB
bc82442 7.85 MiB 9.44 MiB 1.59 MiB
50bdfad 8.32 MiB 9.43 MiB 1.10 MiB

Previous results on branch: chore/only-add-load-debug-image-integration-for-obfuscated-apps

Startup times

Revision Plain With Sentry Diff
9eed114 1261.22 ms 1269.19 ms 7.96 ms
f1215c6 1260.88 ms 1276.71 ms 15.84 ms
a76ebe3 1272.29 ms 1284.84 ms 12.55 ms
b0cee7d 1253.08 ms 1265.88 ms 12.80 ms
9015295 1266.65 ms 1284.57 ms 17.92 ms

App size

Revision Plain With Sentry Diff
9eed114 7.85 MiB 9.44 MiB 1.59 MiB
f1215c6 7.85 MiB 9.45 MiB 1.59 MiB
a76ebe3 8.43 MiB 10.01 MiB 1.58 MiB
b0cee7d 8.43 MiB 10.01 MiB 1.58 MiB
9015295 8.43 MiB 10.01 MiB 1.58 MiB

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 496.80 ms 538.72 ms 41.92 ms
Size 6.54 MiB 7.53 MiB 1015.19 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6078ddc 385.72 ms 463.61 ms 77.89 ms
6e9c5a2 392.32 ms 498.51 ms 106.19 ms
7659cbe 503.66 ms 570.09 ms 66.43 ms
72dfc83 298.62 ms 340.14 ms 41.52 ms
26e955b 369.52 ms 458.60 ms 89.07 ms
d089990 361.67 ms 442.50 ms 80.83 ms
6edf8b8 486.35 ms 547.52 ms 61.17 ms
256df44 447.58 ms 485.84 ms 38.25 ms
f6f3d25 349.44 ms 438.90 ms 89.46 ms
3f23617 385.77 ms 476.10 ms 90.33 ms

App size

Revision Plain With Sentry Diff
6078ddc 6.34 MiB 7.29 MiB 967.80 KiB
6e9c5a2 6.35 MiB 7.42 MiB 1.07 MiB
7659cbe 6.46 MiB 7.48 MiB 1.03 MiB
72dfc83 5.94 MiB 6.92 MiB 1001.71 KiB
26e955b 6.27 MiB 7.20 MiB 956.49 KiB
d089990 6.34 MiB 7.28 MiB 967.79 KiB
6edf8b8 6.44 MiB 7.43 MiB 1010.28 KiB
256df44 6.52 MiB 7.59 MiB 1.06 MiB
f6f3d25 6.27 MiB 7.20 MiB 958.60 KiB
3f23617 5.94 MiB 6.96 MiB 1.02 MiB

Previous results on branch: chore/only-add-load-debug-image-integration-for-obfuscated-apps

Startup times

Revision Plain With Sentry Diff
9015295 520.29 ms 576.10 ms 55.82 ms
a76ebe3 483.61 ms 571.62 ms 88.01 ms
f1215c6 442.84 ms 498.73 ms 55.89 ms
b0cee7d 460.00 ms 523.17 ms 63.17 ms
9eed114 491.39 ms 548.68 ms 57.29 ms

App size

Revision Plain With Sentry Diff
9015295 6.44 MiB 7.43 MiB 1013.20 KiB
a76ebe3 6.44 MiB 7.43 MiB 1013.73 KiB
f1215c6 6.54 MiB 7.53 MiB 1015.87 KiB
b0cee7d 6.44 MiB 7.43 MiB 1013.73 KiB
9eed114 6.54 MiB 7.53 MiB 1015.19 KiB

@buenaflor buenaflor merged commit 69ec1e8 into main Jun 20, 2025
162 of 163 checks passed
@buenaflor buenaflor deleted the chore/only-add-load-debug-image-integration-for-obfuscated-apps branch June 20, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants