Skip to content

Add message parameter to captureException #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 17, 2025
Merged

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Apr 22, 2025

📜 Description

Fixes #2844

💡 Motivation and Context

This is useful if you want to add additional context to a captured exception

💚 How did you test it?

Added tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Sorry, something went wrong.

ueman added 2 commits April 22, 2025 19:00

Verified

This commit was signed with the committer’s verified signature.
ueman Jonas Uekötter

Verified

This commit was signed with the committer’s verified signature.
ueman Jonas Uekötter
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (78793c5) to head (826957e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2882      +/-   ##
==========================================
+ Coverage   87.60%   87.63%   +0.02%     
==========================================
  Files         278      278              
  Lines        9176     9176              
==========================================
+ Hits         8039     8041       +2     
+ Misses       1137     1135       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ueman and others added 5 commits April 22, 2025 19:11

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
ueman Jonas Uekötter

Verified

This commit was signed with the committer’s verified signature.
ueman Jonas Uekötter

Verified

This commit was signed with the committer’s verified signature.
ueman Jonas Uekötter
…essage

Verified

This commit was signed with the committer’s verified signature.
ueman Jonas Uekötter
@ueman ueman marked this pull request as draft April 23, 2025 19:04

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ueman
Copy link
Collaborator Author

ueman commented Apr 25, 2025

@denrase What am I doing wrong when regenerating the mocks via the build_runner? Somehow, I get a bunch of incompatible code and I don't really understand why

@denrase
Copy link
Collaborator

denrase commented Apr 30, 2025

@ueman Had the same issues today. I resolved it by switching to the beta flutter channel, upgrading to the latest version and running flutter pub run build_runner build there from the sentry-dart/flutter directory.

@denrase
Copy link
Collaborator

denrase commented Apr 30, 2025

@ueman Sorry for the late reply 🙈

ueman and others added 3 commits May 13, 2025 07:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
ueman Jonas Uekötter

Verified

This commit was signed with the committer’s verified signature.
ueman Jonas Uekötter
@ueman ueman marked this pull request as ready for review May 13, 2025 05:51
@ueman ueman requested a review from denrase as a code owner May 13, 2025 05:51
@ueman
Copy link
Collaborator Author

ueman commented May 14, 2025

@denrase @buenaflor I'm not sure whether this is should be considered a breaking change, but if so, it would be nice to have it included in v9 :D This is also ready for review and the failing checks are due to a missing auth token for the integration test, presumable due to me being an outside contributor.

@buenaflor
Copy link
Contributor

afaict it's not a breaking change but I'll have a closer look

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ueman
Copy link
Collaborator Author

ueman commented May 19, 2025

@buenaflor Are there any news?

@buenaflor
Copy link
Contributor

Changes look fine to me but I wanna merge this once v9 is out

ueman added 2 commits June 16, 2025 15:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ueman
Copy link
Collaborator Author

ueman commented Jun 17, 2025

@buenaflor Friendly ping to get this merged :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@buenaflor buenaflor merged commit 998969c into getsentry:main Jun 17, 2025
140 of 144 checks passed
@ueman ueman deleted the add-message branch June 17, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to add a message to captureException
3 participants