-
-
Notifications
You must be signed in to change notification settings - Fork 261
Add message parameter to captureException #2882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2882 +/- ##
==========================================
+ Coverage 87.60% 87.63% +0.02%
==========================================
Files 278 278
Lines 9176 9176
==========================================
+ Hits 8039 8041 +2
+ Misses 1137 1135 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@denrase What am I doing wrong when regenerating the mocks via the build_runner? Somehow, I get a bunch of incompatible code and I don't really understand why |
@ueman Had the same issues today. I resolved it by switching to the beta flutter channel, upgrading to the latest version and running |
@ueman Sorry for the late reply 🙈 |
@denrase @buenaflor I'm not sure whether this is should be considered a breaking change, but if so, it would be nice to have it included in v9 :D This is also ready for review and the failing checks are due to a missing auth token for the integration test, presumable due to me being an outside contributor. |
afaict it's not a breaking change but I'll have a closer look |
@buenaflor Are there any news? |
Changes look fine to me but I wanna merge this once v9 is out |
@buenaflor Friendly ping to get this merged :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
📜 Description
Fixes #2844
💡 Motivation and Context
This is useful if you want to add additional context to a captured exception
💚 How did you test it?
Added tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps