-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js-sdk): support release health #2546
base: feat/js-sdk-integration
Are you sure you want to change the base?
feat(js-sdk): support release health #2546
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- support release health ([#2546](https://github.com/getsentry/sentry-dart/pull/2546)) If none of the above apply, you can opt out of this check by adding |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/js-sdk-integration #2546 +/- ##
============================================================
+ Coverage 70.98% 88.12% +17.14%
============================================================
Files 17 119 +102
Lines 579 4397 +3818
============================================================
+ Hits 411 3875 +3464
- Misses 168 522 +354 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the definition of session in JS is about to change on v9
might be a good idea to line it up, so only ship the Dart on JS session using the v9 sdk. you could piggy back on their alpha to ship your on alphas etc
@@ -276,7 +276,7 @@ class SentryOptions { | |||
/// breadcrumbs. | |||
/// In a Flutter environment, this setting also toggles recording of `debugPrint` calls. | |||
/// `debugPrint` calls are only recorded in release builds, though. | |||
bool enablePrintBreadcrumbs = true; | |||
bool enablePrintBreadcrumbs = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change needed to be part of the web support? it could have side effects of itself worth tracking as a separate change probably done before the big web support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is temporary for testing, on web with the js sdk integration this seems to run into a recursion so I've disabled it for now I will revert it back after I fixed the issue
note: currently the PR that this is based on is not merged yet so bunch of unrelated changes will show up for now |
📜 Description
Built on top of PR #2489
💡 Motivation and Context
Adds support for sessions / release health.
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps