Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Dec 30, 2025

📜 Description

Converts SentryNetworkTrackingIntegration to Swift

💡 Motivation and Context

Objectives:

  • Reduce ObjC
  • Reliance on singletons

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@linear
Copy link

linear bot commented Dec 30, 2025

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.765%. Comparing base (406b0d4) to head (bdc5f85).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7106       +/-   ##
=============================================
+ Coverage   84.714%   84.765%   +0.051%     
=============================================
  Files          459       459               
  Lines        27496     27510       +14     
  Branches     12121     12131       +10     
=============================================
+ Hits         23293     23319       +26     
+ Misses        4160      4149       -11     
+ Partials        43        42        -1     
Files with missing lines Coverage Δ
Sources/Sentry/SentrySDKInternal.m 84.583% <100.000%> (-0.064%) ⬇️
Sources/Sentry/SentrySwizzleWrapperHelper.m 100.000% <100.000%> (ø)
Sources/Swift/Core/Integrations/Integrations.swift 100.000% <100.000%> (ø)
...nce/Network/SentryNetworkTrackingIntegration.swift 100.000% <100.000%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406b0d4...bdc5f85. Read the comment docs.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Dec 30, 2025
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.53 ms 1243.49 ms 18.96 ms
Size 24.14 KiB 1.03 MiB 1.00 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
139db8b 1231.50 ms 1258.19 ms 26.69 ms
56f9cc6 1209.47 ms 1236.84 ms 27.37 ms
0529194 1237.23 ms 1254.67 ms 17.44 ms
3b059e5 1229.29 ms 1256.68 ms 27.40 ms
55f739c 1226.06 ms 1248.78 ms 22.71 ms
fae97e5 1229.20 ms 1256.27 ms 27.06 ms
7b3399c 1193.35 ms 1227.38 ms 34.03 ms
5ef2eed 1229.96 ms 1260.80 ms 30.84 ms
45482a6 1225.88 ms 1254.27 ms 28.39 ms
7a8b167 1223.12 ms 1251.61 ms 28.49 ms

App size

Revision Plain With Sentry Diff
139db8b 23.75 KiB 920.64 KiB 896.89 KiB
56f9cc6 23.75 KiB 913.63 KiB 889.88 KiB
0529194 23.74 KiB 891.02 KiB 867.28 KiB
3b059e5 23.75 KiB 980.81 KiB 957.06 KiB
55f739c 23.75 KiB 858.73 KiB 834.98 KiB
fae97e5 23.75 KiB 912.37 KiB 888.62 KiB
7b3399c 23.75 KiB 946.68 KiB 922.94 KiB
5ef2eed 24.14 KiB 1023.18 KiB 999.04 KiB
45482a6 23.75 KiB 919.91 KiB 896.16 KiB
7a8b167 24.14 KiB 1.01 MiB 1013.98 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants