feat(sourcemaps): Support injecting indexed sourcemaps #2470

szokeasaurusrex · 2025-04-25T12:47:03Z

Closes #2463
Closes #2466

szokeasaurusrex · 2025-04-25T12:51:21Z

Cargo.toml

+[patch.crates-io]
+sourcemap = { git = "https://github.com/getsentry/rust-sourcemap.git", rev = "e8dff4fbb74f346d0f13a2f547cedf4b5fb4e83f" }


Allows us to use stuff from getsentry/rust-sourcemap#119 and getsentry/rust-sourcemap#118. We will need to release these PRs upstream before this PR can be merged

loewenheim

The injection procedure itself looks good. See comments about the matching logic though.

src/utils/sourcemaps.rs

src/utils/sourcemaps/inject.rs

szokeasaurusrex

@loewenheim I have addressed your comments. Plan to also add some integration tests – in the meantime, please let me know if you have other feedback

szokeasaurusrex

@loewenheim, I have added an integration test. Do you think any more changes need to be made to this PR? If not, I'll merge getsentry/rust-sourcemap#119 and getsentry/rust-sourcemap#118, release those, update this PR to depend on the new version, and mark it as ready for review

loewenheim

Looks good, apart from a leftover comment.

src/utils/sourcemaps.rs

szokeasaurusrex

Postponing merge until #2482 is addressed – I want to make sure that the injection behavior for non-indexed sourcemaps is unchanged

Closes #2463 Closes #2466

Depends on #2470

szokeasaurusrex requested a review from loewenheim April 25, 2025 12:48

szokeasaurusrex commented Apr 25, 2025

View reviewed changes

loewenheim reviewed Apr 25, 2025

View reviewed changes

src/utils/sourcemaps.rs Outdated Show resolved Hide resolved

src/utils/sourcemaps/inject.rs Outdated Show resolved Hide resolved

szokeasaurusrex force-pushed the szokeasaurusrex/use-injection branch from 75bc7c4 to e88d1b1 Compare April 28, 2025 13:07

szokeasaurusrex commented Apr 28, 2025

View reviewed changes

szokeasaurusrex requested a review from loewenheim April 28, 2025 13:08

szokeasaurusrex force-pushed the szokeasaurusrex/use-injection branch 3 times, most recently from 853981c to 4ef911c Compare April 28, 2025 13:38

szokeasaurusrex mentioned this pull request Apr 28, 2025

ref: Rename fixup_js_file_end #2475

Merged

szokeasaurusrex force-pushed the szokeasaurusrex/use-injection branch from 4ef911c to aa9493a Compare April 29, 2025 09:54

szokeasaurusrex commented Apr 29, 2025

View reviewed changes

loewenheim approved these changes Apr 29, 2025

View reviewed changes

src/utils/sourcemaps.rs Outdated Show resolved Hide resolved

szokeasaurusrex force-pushed the szokeasaurusrex/use-injection branch 3 times, most recently from f8c46b3 to 40af3a9 Compare April 29, 2025 13:44

szokeasaurusrex marked this pull request as ready for review April 29, 2025 13:44

szokeasaurusrex force-pushed the szokeasaurusrex/use-injection branch from 40af3a9 to 83d21a9 Compare April 30, 2025 11:30

szokeasaurusrex commented Apr 30, 2025

View reviewed changes

szokeasaurusrex force-pushed the szokeasaurusrex/use-injection branch from 83d21a9 to bd121fc Compare April 30, 2025 11:48

szokeasaurusrex added 2 commits April 30, 2025 14:33

test(sourcemaps): Assert injection outputs

Verified

This commit was signed with the committer’s verified signature.

bschoenmaeckers Bas Schoenmaeckers

GPG key ID: 07E1625F68B4F88B

Verified
Learn about vigilant mode

Loading
Loading status checks…

102820b

szokeasaurusrex force-pushed the szokeasaurusrex/use-injection branch from bd121fc to 01fc527 Compare April 30, 2025 13:00

szokeasaurusrex merged commit 01fc527 into master Apr 30, 2025
17 checks passed

szokeasaurusrex deleted the szokeasaurusrex/use-injection branch April 30, 2025 14:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(sourcemaps): Support injecting indexed sourcemaps #2470

feat(sourcemaps): Support injecting indexed sourcemaps #2470

szokeasaurusrex commented Apr 25, 2025

szokeasaurusrex Apr 25, 2025

loewenheim left a comment

szokeasaurusrex left a comment

szokeasaurusrex left a comment

loewenheim left a comment

szokeasaurusrex left a comment

		[patch.crates-io]
		sourcemap = { git = "https://github.com/getsentry/rust-sourcemap.git", rev = "e8dff4fbb74f346d0f13a2f547cedf4b5fb4e83f" }

feat(sourcemaps): Support injecting indexed sourcemaps #2470

feat(sourcemaps): Support injecting indexed sourcemaps #2470

Conversation

szokeasaurusrex commented Apr 25, 2025

szokeasaurusrex Apr 25, 2025

Choose a reason for hiding this comment

loewenheim left a comment

Choose a reason for hiding this comment

szokeasaurusrex left a comment

Choose a reason for hiding this comment

szokeasaurusrex left a comment

Choose a reason for hiding this comment

loewenheim left a comment

Choose a reason for hiding this comment

szokeasaurusrex left a comment

Choose a reason for hiding this comment