Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(anomaly_detection): support experiments with slope #1663

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

ram-senth
Copy link
Member

No description provided.

@ram-senth ram-senth force-pushed the anomaly_detection/slope_logic branch from 2624539 to 63e8415 Compare January 6, 2025 23:38
@ram-senth ram-senth force-pushed the anomaly_detection/slope_logic branch from 63e8415 to 8cb3328 Compare January 6, 2025 23:38
@ram-senth ram-senth changed the title chore(anomaly_detection): support experiments with slopw chore(anomaly_detection): support experiments with slope Jan 6, 2025
@ram-senth ram-senth marked this pull request as ready for review January 6, 2025 23:56
@ram-senth ram-senth requested a review from a team as a code owner January 6, 2025 23:56
@@ -195,7 +196,9 @@ def detect(
raise ServerError("History values and timestamps are not of the same length")

if len(self.history_values) - self.window_size + 1 != len(self.history_mp):
raise ServerError("Matrix profile is not of the right length.")
raise ServerError(
f"Matrix profile is not of the right length. expected: {len(self.history_values) - self.window_size + 1}, actual: {len(self.history_mp)}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great inclusion of more specific message 👏

Copy link
Member

@aayush-se aayush-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ram-senth ram-senth merged commit 050622b into main Jan 7, 2025
11 checks passed
@ram-senth ram-senth deleted the anomaly_detection/slope_logic branch January 7, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants