feat(spanv2): Implement PII scrubbing #5168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
The tests are great, but also extremely verbose to copy paste for each |
loewenheim
force-pushed
the
sebastian/scrub-spans-v2
branch
from
a2b24ec to
d801f07
Compare
Dav1dde
approved these changes
Oct 15, 2025
jjbayer
reviewed
Oct 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
loewenheim
force-pushed
the
sebastian/scrub-spans-v2
branch
from
53acf2e to
0e73649
Compare
loewenheim
force-pushed
the
sebastian/scrub-spans-v2
branch
from
20c9dbd to
10be263
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the PII scrubbing logic from logs to spans V2 pretty much unchanged. I ported over most tests as well, the one exception being
test_ourlog_extraction_default_pii_scrubbing_does_not_scrub_default_attributesbecause I couldn't make it work—there's some difference in the pipelines between logs and spans that makes this nontrivial.I also added some tests for the scrubbing of span links (since they can have attributes of their own), everything is working as expected there.
Closes #5131. Closes RELAY-155.