Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Provide the ability to override HTTPTransport configuration #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattrobenolt
Copy link
Contributor

@mattrobenolt mattrobenolt commented Dec 7, 2018

Fixes #221, #169, #150

edit @kamilogorek: and #117

@dcramer
Copy link
Member

dcramer commented Dec 7, 2018

I might take a stab at expanding on this since this isn't priority, but I think we'd want to get some basic test coverage in.

@mattrobenolt
Copy link
Contributor Author

I'm going to change this to not pull in certifi by default as discussed, since this makes it easy to pull in certifi yourself now, and I'll just add documentation on how to do this.

@pedro-te
Copy link

This is an issue for me as well. Our sentry server has an SSL cert signed by an internal CA and we need to be able to pass a custom certificate pool. Any chance this can be merged if the conflict is fixed?

Also, the certificate signed by unknown authority error is completely ignored which is frustrating. Spent some time trying to figure out what I was doing wrong because this wasn't throwing any errors until I tried to run the example.go and it threw the certificate signed by unknown authority error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants