Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Commits on Nov 9, 2017

  1. Return error when waiting for packet to be sent

    The client's capture method returns an error channel that according to
    the docs is intended to be used for checking if a packet was sent
    successfully whenever that is important.
    
    The `...AndWait` methods use this channel, but only to wait. They do
    not capture the possible error coming from that channel.
    
    The changes in this commit suggest to use the error and return it, so
    that a user may check whether a packet was sent successfully using the
    top level methods (like `CaptureMessageAndWait`), instead of having to
    write their own.
    
    **Breaking changes**:
    
    The signatures of the following methods are changed:
    
    ```
    - [Client.]CaptureMessageAndWait
    - [Client.]CaptureErrorAndWait
    - [Client.]CapturePanicAndWait
    ```
    
    Work on getsentry#84
    Valentin Krasontovitsch committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    3c52672 View commit details
    Browse the repository at this point in the history