Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
==========================================
+ Coverage 89.15% 89.49% +0.34%
==========================================
Files 113 114 +1
Lines 20692 21564 +872
==========================================
+ Hits 18447 19298 +851
- Misses 2245 2266 +21
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lcian
approved these changes
Sep 15, 2026
lcian
left a comment
Member
There was a problem hiding this comment.
As we discussed, I don't foresee any cases where we would need to carry around more "request context" other than this timestamp, and I think carrying this in a task-local or similar implicit "context" would likely be error-prone. So, I'm fine with this approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture one timestamp per HTTP request and pass it through metadata creation, service calls, and backend expiry checks. Previously, backends sampled time independently. A slow request could therefore use different times for creation, expiry checks, and TTI renewal.
Use an explicit timestamp parameter to keep the interface small and dependencies visible. Endpoints extract the timestamp, and the auth wrapper forwards it like the other operation arguments. Reuse it across all batch items, tiered calls, and retries.
Background renewals and cleanup start separate operations and use fresh timestamps for liveness checks. This prevents time spent waiting in a queue from authorizing renewal of an expired object. Renewal deadlines still come from the original read, so queue delays do not extend retention.
Keep multipart modification timestamps and cleanup grace periods unchanged. They serve separate purposes from object access and expiry.