Conversation
Consume error and ignored response bodies so their HTTP connections can be reused. Keep batch multipart responses streaming because multer does not expose its underlying stream after parse errors.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
+ Coverage 89.08% 89.10% +0.01%
==========================================
Files 112 114 +2
Lines 20560 20748 +188
==========================================
+ Hits 18316 18487 +171
- Misses 2244 2261 +17
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lcian
marked this pull request as ready for review
September 14, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust client now consumes response bodies on error and on successful paths that otherwise discard them, allowing the underlying HTTP connections to return cleanly to the connection pool.
Successful GET responses remain caller-owned streams, while JSON responses continue to be consumed by deserialization.
Special case: batch multipart responses remain non-drained, as that would require buffering the whole batch response at once due to a limitation in
multer.