ref(rust-client): Use typed queries for resumable API - #628
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
==========================================
+ Coverage 89.08% 89.12% +0.03%
==========================================
Files 112 112
Lines 20560 20550 -10
==========================================
- Hits 18316 18315 -1
+ Misses 2244 2235 -9
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lcian
marked this pull request as ready for review
September 14, 2026 13:48
Member
Author
|
@jan-auer do you think it's worth it to use this internally also in the GCS backend? (as a follow-up) |
jan-auer
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumable upload requests now serialize
upload_typeandsessionthrough typed Serde query structs and Reqwest's query API.There was another place where we do this which is the multipart API, but given that we're going to remove it I'm not gonna spend time on it.