Skip to content

ref(rust-client): Use typed queries for resumable API - #628

Merged
lcian merged 1 commit into
mainfrom
ref/use-typed-resumable-queries
Sep 15, 2026
Merged

lcian merged 1 commit into
mainfrom
ref/use-typed-resumable-queries

Conversation

@lcian

@lcian lcian commented Sep 14, 2026

Copy link
Copy Markdown
Member

Resumable upload requests now serialize upload_type and session through typed Serde query structs and Reqwest's query API.
There was another place where we do this which is the multipart API, but given that we're going to remove it I'm not gonna spend time on it.

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.12%. Comparing base (a48ebfc) to head (afa3b8f).

Files with missing lines Patch % Lines
clients/rust/src/resumable.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   89.08%   89.12%   +0.03%     
==========================================
  Files         112      112              
  Lines       20560    20550      -10     
==========================================
- Hits        18316    18315       -1     
+ Misses       2244     2235       -9     
Components Coverage Δ
Rust Backend 93.48% <ø> (ø)
Rust Client 73.14% <0.00%> (+0.44%) ⬆️
Python Client 93.56% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lcian lcian changed the title ref(rust-client): Use typed resumable queries ref(rust-client): Use typed queries for resumable API Sep 14, 2026
@lcian
lcian marked this pull request as ready for review September 14, 2026 13:48
@lcian
lcian requested a review from a team as a code owner September 14, 2026 13:48
@lcian

lcian commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

@jan-auer do you think it's worth it to use this internally also in the GCS backend? (as a follow-up)

@lcian
lcian merged commit e84bf78 into main Sep 15, 2026
26 checks passed
@lcian
lcian deleted the ref/use-typed-resumable-queries branch September 15, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants