fix(scheduler): preserve public dispatch visibility - #1182
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e0a3028. Configure here.
dcramer
marked this pull request as ready for review
August 2, 2026 02:27
dcramer
added a commit
that referenced
this pull request
Aug 2, 2026
## Summary - replace `Source.type: "pub" | "priv"` with `Source.visibility: "public" | "private"` - hard-cut runtime, plugin, scheduler, memory, test, and eval consumers to the canonical vocabulary - migrate persisted conversation `source_json` records to the new field and values This PR is stacked on #1182 and should be retargeted to `main` after that PR merges. ## Breaking change Plugin authors must update source construction and reads from `type`/`pub`/`priv` to `visibility`/`public`/`private`. There is no compatibility reader; durable conversation records are upgraded by the included SQL migration. ## Testing - `pnpm typecheck` - `pnpm --filter @sentry/junior exec vitest run tests/unit/plugin-api-source.test.ts tests/unit/runtime/source.test.ts tests/unit/plugins/agent-hooks.test.ts tests/integration/heartbeat.test.ts tests/integration/slack-schedule-tools.test.ts tests/integration/conversation-sql.test.ts` (118 tests) - `pnpm --filter @sentry/junior-memory test` (89 tests) - `pnpm --filter @sentry/junior-github exec vitest run tests/github-plugin.test.ts` (73 tests) - `pnpm --filter @sentry/junior-plugin-api build` - `pnpm --filter @sentry/junior-scheduler build` - `pnpm lint` passed all source and architecture checks; the final `publint` packaging step failed locally because it could not find pnpm's tarball despite `pnpm pack` exiting successfully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduled task dispatches now preserve the destination conversation's stored visibility through execution and transcript reporting, so tasks delivered to public Slack channels remain public instead of being redacted as private.
The conversation store is the single durable owner of destination visibility. Scheduler metadata and live Slack event metadata update that canonical record, and the agent-run boundary reads it when a resumed run has no live value. Conversation and channel ID prefixes are never inspected.
If visibility is unavailable, privacy-sensitive consumers warn and fail closed without persisting a private default. A task's source conversation never determines the destination conversation's visibility.