fix(slack): wake passive router on outstanding-request answers - #1141
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
fix(slack): wake passive router on outstanding-request answers#1141sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
The subscribed classifier treated bot/human answers to Junior's own asks as side conversation, so threads stayed silent until an explicit re-tag. Teach routing that fulfilling an outstanding assistant request is a turn-back, and stop bare @botUserId mentions from preflight-skipping as other-party. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subscribed-thread classifier treated answers to Junior's own asks as side conversation, so threads stayed silent until someone re-tagged Junior.
Evidence
In
#jr-cramer, Junior asked staging for raw validation evidence, staging replied with that evidence, and prod skipped both replies asside_conversation(00:28:50,00:28:52). David had to@jr ^to resume.Outstanding-request turn-back
When Junior's latest prior message is an ask for info/evidence and the latest message supplies it, route
should_reply=trueeven without an explicit mention. That includes answers from other bots. Confidence threshold is lowered for those cases.Bare bot-id mention preflight
Normalized
@U0BOT/<@U0BOT>self-mentions no longer preflight-skip asnamed_mention/slack_mentionother-party.botUserIdis wired lazily through factory → reply policy → decision preflight.Verification
pnpm --filter @sentry/junior exec tsc -p tsconfig.json --noEmitRisk
Slightly more replies after Junior asks another person/bot for details. Still fails closed on plain status chatter and human-to-human coordination.
Requested by David Cramer via Junior.
--
View Junior Session