Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): Restructure modules for packaging #31

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Sep 17, 2024

The main issue this fixes is this error seen after installing through pip from pypi

Traceback (most recent call last):
  File "/opt/homebrew/bin/devservices", line 5, in <module>
    from main import main
ModuleNotFoundError: No module named 'main'

It didn't make sense to me to have a module named src for packaging purposes. The alternatives for getting this to work is to have a devservices directory inside src, or rename src to devservices. This implements those changes, and also fixes some typing errors that were somehow missed

I've tested this through a

python -m build
pip install dist/devservices-0.0.1.tar.gz

@hubertdeng123 hubertdeng123 changed the title Restructure modules for packaging feat(release): Restructure modules for packaging Sep 17, 2024
@hubertdeng123 hubertdeng123 force-pushed the hubertdeng123/edit-module-path branch from dca4937 to fd407b6 Compare September 17, 2024 20:04
@hubertdeng123 hubertdeng123 merged commit c78bc36 into main Sep 17, 2024
8 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/edit-module-path branch September 17, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants