Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(docker-compose): Starting to refactor docker compose logic #198

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

IanWoodard
Copy link
Member

This refactor aims to enable us to support more specific use-cases for various commands and help us fix some bugs with the current implementation along the way.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 60.86957% with 27 lines in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (83e6330) to head (fd5b7a1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/commands/status.py 29.41% 12 Missing ⚠️
devservices/commands/down.py 68.75% 5 Missing ⚠️
devservices/commands/logs.py 70.58% 5 Missing ⚠️
devservices/commands/up.py 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   93.03%   91.48%   -1.55%     
==========================================
  Files          22       22              
  Lines        1507     1551      +44     
==========================================
+ Hits         1402     1419      +17     
- Misses        105      132      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanWoodard IanWoodard merged commit 2b513fc into main Jan 6, 2025
12 of 14 checks passed
@IanWoodard IanWoodard deleted the iw/refactoring-get-docker-compose-commands branch January 6, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants