Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(down): Use stop rather than down to avoid removing containers #194

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

IanWoodard
Copy link
Member

Ideally we shouldn't be removing containers when we run down since it makes bringing things back up slower and negatively impacts the functionality of purge.
https://getsentry.atlassian.net/browse/DEVINFRA-571

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (f22580a) to head (08c6022).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files          22       22           
  Lines        1477     1477           
=======================================
  Hits         1372     1372           
  Misses        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanWoodard IanWoodard merged commit e40aa4a into main Jan 2, 2025
14 checks passed
@IanWoodard IanWoodard deleted the iw/use-stop branch January 2, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants