Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump healthcheck timeout to 45 seconds #190

Merged
merged 2 commits into from
Dec 30, 2024
Merged

chore: Bump healthcheck timeout to 45 seconds #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95f18e7
bump healthcheck timeout to 45 seconds
hubertdeng123 Dec 30, 2024
6781f22
fix test
hubertdeng123 Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devservices/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@
DEVSERVICES_CACHE_DIR, "latest_version.txt"
)
DEVSERVICES_LATEST_VERSION_CACHE_TTL = timedelta(minutes=15)
HEALTHCHECK_TIMEOUT = 30
HEALTHCHECK_TIMEOUT = 45
HEALTHCHECK_INTERVAL = 5
2 changes: 1 addition & 1 deletion tests/commands/test_up.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ def test_up_docker_compose_container_healthcheck_failed(
assert "Starting clickhouse" in captured.out.strip()
assert "Starting redis" in captured.out.strip()
assert (
"Container container1 did not become healthy within 30 seconds."
"Container container1 did not become healthy within 45 seconds."
in captured.out.strip()
)

Expand Down
Loading