Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(down): Adding error handling to get_non_shared_remote_dependencies #180

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

IanWoodard
Copy link
Member

Currently we don't handle exceptions for get_non_shared_remote_dependencies, which this change aims to address.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.48%. Comparing base (2af25a6) to head (5a9dcef).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/commands/down.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   92.75%   92.48%   -0.28%     
==========================================
  Files          22       22              
  Lines        1339     1344       +5     
==========================================
+ Hits         1242     1243       +1     
- Misses         97      101       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanWoodard IanWoodard merged commit e12cf85 into main Dec 16, 2024
12 of 14 checks passed
@IanWoodard IanWoodard deleted the iw/handle-dep-error branch December 16, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants