ref(update): Adding caching to checking for latest version #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we hit the GitHub api each time a command is run which can lead to being rate limited and adds additional bloat that makes commands feel less snappy. To remedy this, this change adds a simple caching mechanism that stores the version it retrieves from the GitHub api for 15 minutes before refetching again. This should be often enough to still promptly inform users of updates while not sending unnecessary requests to the GitHub api.
I also moved
check_for_update
out of commands and into utils where I believe it belongs. I also added some preliminary testing forcheck_for_update
.