Skip to content

chore(deps): bump mini_chromium - #164

Merged
jpnurmi merged 2 commits into
getsentryfrom
jpnurmi/fix/cxx17
Jul 27, 2026
Merged

chore(deps): bump mini_chromium#164
jpnurmi merged 2 commits into
getsentryfrom
jpnurmi/fix/cxx17

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Bumps mini_chromium to a revision with the following fix:

The fix was needed for sentry-native's C++17 builds with ClangCL and [-Werror,-Wdeprecated-redundant-constexpr-static-def]:

2026-07-24T17:36:37.9268717Z   In file included from D:\a\sentry-native\sentry-native\src\backends\sentry_backend_crashpad.cpp:60:
2026-07-24T17:36:37.9270072Z   In file included from D:\a\sentry-native\sentry-native\external\crashpad\client/crashpad_client.h:26:
2026-07-24T17:36:37.9453990Z D:\a\sentry-native\sentry-native\external\crashpad\third_party\mini_chromium\mini_chromium\base/containers/span.h(363,52): error : out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Werror,-Wdeprecated-redundant-constexpr-static-def] [C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\cmake1\sentry.vcxproj]
2026-07-24T17:36:38.3245295Z FAILED

@jpnurmi
jpnurmi force-pushed the jpnurmi/fix/cxx17 branch from 4e584cc to 8dbed15 Compare July 27, 2026 09:31
@jpnurmi
jpnurmi merged commit aae505d into getsentry Jul 27, 2026
27 checks passed
@jpnurmi
jpnurmi deleted the jpnurmi/fix/cxx17 branch July 27, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants