Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jan 9, 2026

The Sentry esbuild plugin requires files with .js extension to properly inject debug IDs and upload source maps.

This changes the build process to:

  1. Build to dist/craft.js first
  2. Let the Sentry plugin inject debug IDs and upload source maps
  3. Rename to dist/craft (the final executable)
  4. Clean up any remaining source map files

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@BYK BYK changed the title fix: build to .js file first for Sentry sourcemap upload fix: build to .js for Sentry sourcemap upload Jan 9, 2026
@BYK BYK marked this pull request as ready for review January 9, 2026 15:08
@BYK BYK enabled auto-merge (squash) January 9, 2026 16:46
@BYK BYK merged commit 8f02180 into master Jan 9, 2026
18 checks passed
@BYK BYK deleted the fix/sourcemaps-js-extension branch January 9, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants