fix: add shebang to binary and fix PR CI environment #699
+8
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build issues introduced after the Sentry integration PR:
Changes
Add shebang to built binary - The esbuild output was missing
#!/usr/bin/env node, causing the shell to execute the JavaScript file as a shell script. The build script now adds the shebang if not already present.Fix environment expression for PR builds - Changed
environment: ${{ github.ref == 'refs/heads/master' && 'production' || '' }}toenvironment: ${{ github.ref == 'refs/heads/master' && 'production' }}. The empty string fallback was causing the Artifacts Upload job to be skipped on PRs.Clean up inject file - Removed leading blank line from
src/utils/import-meta-url.js.Fixes
./dist/craft: Permission denied- Fixed by adding chmod./dist/craft: line 1: var: command not found- Fixed by adding shebang|| ''from environment expression