fix(init): add size guard and deduplicate JSON minification in preReadCommonFiles#713
Merged
fix(init): add size guard and deduplicate JSON minification in preReadCommonFiles#713
Conversation
…dCommonFiles - Add stat check before reading files in preReadCommonFiles, skipping files larger than MAX_FILE_BYTES (256KB). Prevents memory spikes from large files like Gemfile.lock. - Extract minifyJson() helper and use it in both preReadCommonFiles and readSingleFile to eliminate duplicated JSON.stringify(JSON.parse()) logic. Made-with: Cursor
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Docs
Init
Other
Bug Fixes 🐛Dashboard
Init
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1573 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.36% 95.36% —%
==========================================
Files 232 232 —
Lines 33927 33927 —
Branches 0 0 —
==========================================
+ Hits 32354 32354 —
- Misses 1573 1573 —
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for
preReadCommonFiles:Per-file size guard -- Stat files before reading and skip anything over
MAX_FILE_BYTES(256KB). Prevents memory spikes from large files likeGemfile.lockthat could eat the entire 512KB budget in one read.Deduplicate JSON minification -- Extract
minifyJson()helper used by bothpreReadCommonFilesandreadSingleFile. Prevents the two identicalJSON.stringify(JSON.parse())blocks from drifting out of sync.Test plan
Made with Cursor