fix: event 404 hint should suggest different project, not repeat failing command#492
Merged
fix: event 404 hint should suggest different project, not repeat failing command#492
Conversation
…ing command Address unresolved Bugbot review from PR #491: the 'Try:' hint in fetchEventWithContext repeated the exact command that just failed. Changed to use a <project> placeholder so it suggests trying a different project, and updated the suggestion bullet to explicitly say 'Search across all projects in the org'.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1044 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 95.77% 95.76% -0.01%
==========================================
Files 180 180 —
Lines 24622 24622 —
Branches 0 0 —
==========================================
+ Hits 23580 23578 -2
- Misses 1042 1044 +2
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #491
Addresses unresolved Bugbot review comment that I missed before merging #491.
Problem
The
Try:hint infetchEventWithContextrepeated the exact command that just produced the 404:Fix
Changed the hint to use a
<project>placeholder to suggest trying a different project, and updated theOr:suggestion to explicitly mention org-wide search: