(2 lines PR) Fix to make "show data labels" works #7363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshiokatsuneo
force-pushed
the
fix/bar_chart_show_data_labels_3
branch
from
d849075 to
3a3fff1
Compare
yoshiokatsuneo
force-pushed
the
fix/bar_chart_show_data_labels_3
branch
from
3a3fff1 to
7c32e7c
Compare
yoshiokatsuneo
changed the title
yoshiokatsuneo
changed the title
yoshiokatsuneo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
After upgraded plotly.js to version2.0, "show data labels" on bar chart does not works but data label is always show.
This happens because plotly.js's "textposition" default value was changed from "none" to "auto".
This PR fixes it by explicitly setting "textposition" to "none" or "inside".
How is this tested?
I confirmed that data labels is shown only when "show data labels" is checked.