Make favorite queries/dashboard order by starred at(favorited at) #7351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshiokatsuneo
force-pushed
the
feat/favorites_order_by_starred_at
branch
2 times, most recently
from
9e612e6 to
0ed92e3
Compare
yoshiokatsuneo
force-pushed
the
feat/favorites_order_by_starred_at
branch
2 times, most recently
from
fd91171 to
d4f21db
Compare
yoshiokatsuneo
force-pushed
the
feat/favorites_order_by_starred_at
branch
from
d4f21db to
da4775e
Compare
yoshiokatsuneo
force-pushed
the
feat/favorites_order_by_starred_at
branch
from
da4775e to
ed90a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Before this PR, favorite dashboards and queries are ordered by "created_at".
So, older dashboards/queries is always at the bottom of the list that is difficult to reach out.
This PR changes the sorting order by "starred at" (the time when user favorited). If the user want to put specific dashboard on the top of the list, the user can do it by just re-favorite it.
How is this tested?
Mobile & Desktop Screenshots/Recordings (if there are UI changes)