Make autocomplete always available #7326
Merged
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshiokatsuneo
force-pushed
the
feat/autocomplete_always_available
branch
from
b522d32 to
40fce1b
Compare
2 tasks
yoshiokatsuneo
force-pushed
the
feat/autocomplete_always_available
branch
from
40fce1b to
8afd656
Compare
eradman
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Before this PR, autocomplete is not available if there are more than 5,000 tokens. The limit is too small for our data warehouse, and probably many data warehouse.
This PR removes the limit, and make autocomplete always available.
Anyway, if each user want to disable autocomplete, they can just disable by themselves, and I think it is better to make it user's choice instead of hard-coded limit.
Also, as tokens are stored on memory even if the autocomplete is disabled, amount of memory consumption does not change.
This PR is derived from the discussion on #7319 .
How is this tested?
I confirmed that the auto complete works smoothly for tokens more than 700,000.