FIX : redash docker image TAG #7280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7280 +/- ##
=======================================
Coverage 64.01% 64.01%
=======================================
Files 163 163
Lines 13410 13410
Branches 1905 1905
=======================================
Hits 8585 8585
Misses 4490 4490
Partials 335 335 |
|
@arikfr |
Thanks, can you approval workflows? |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
The
clean-alltarget in the Makefile still references the Docker image tag from a previous version, which may cause inconsistencies.This PR updates the
cleantarget to reference the latest version of the Docker image. Alternatively, we could consider referencing a specific version that matches the current TAG for better version control.Changes:
clean-alltarget of the Makefile.Please review and share your thoughts. Let me know if the current approach or referencing the corresponding TAG is preferred.
How is this tested?
Related Tickets & Documents
issue : #7279
Mobile & Desktop Screenshots/Recordings (if there are UI changes)