-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Table visualization to React Part 1: Renderer #3963
Merged
Merged
Changes from 20 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3f10ab2
Migrate Table visualization (Renderer) to React
kravets-levko e909f80
Restore all column types except of JSON
kravets-levko c9f09eb
Restore JSON column + fix proptypes
kravets-levko eb3323c
Restore JSON column: refine code and fix bugs
kravets-levko 5048e4d
Refine code
kravets-levko ca8bcc5
Restore search in data
kravets-levko 91fd16f
Restore column sorting
kravets-levko 66f8265
Cleanup: remove angular components (incl. <dynamic-table>)
kravets-levko d9117a4
Minor fixes
kravets-levko a0c56dd
Merge branch 'master' into migrate-visualization-table
kravets-levko 31b3a4e
Fix tests
kravets-levko e662803
Fixes: pagination alignment; re-render visualization on tab change (a…
kravets-levko cd8fb4a
Add tests
kravets-levko 64afeec
Fix search in table: force cast value to string
kravets-levko 6401afa
When visualization options change, compare them deeply to avoid unnec…
kravets-levko 4547ca5
Merge branch 'master' into migrate-visualization-table
kravets-levko c045003
Make tests more stable
kravets-levko c0aad9d
CR1: UI tweaks
kravets-levko bfe02e7
Better align tooltip on table header cells
kravets-levko fdfb760
Add link to GH discussion
kravets-levko 11628f6
Tweak table headings
kravets-levko 61730f6
Merge branch 'master' into migrate-visualization-table
kravets-levko b47ea55
Update to reflect changes in new Ant version
kravets-levko 5b80f43
Fix search input
kravets-levko 675ea83
Increase min width of table headings
kravets-levko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import React from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import { $sanitize } from '@/services/ng'; | ||
|
||
export default function HtmlContent({ children, ...props }) { | ||
return ( | ||
<div | ||
{...props} | ||
dangerouslySetInnerHTML={{ __html: $sanitize(children) }} // eslint-disable-line react/no-danger | ||
/> | ||
); | ||
} | ||
|
||
HtmlContent.propTypes = { | ||
children: PropTypes.string, | ||
}; | ||
|
||
HtmlContent.defaultProps = { | ||
children: '', | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
client/app/components/dynamic-table/default-cell/template.html
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not do it in this PR, but:
$sanitize
with our own function, so we can easily replace the implementation later.