Counter not properly scaled in editor

getredash · Aug 30, 2019 · b54b23c · b54b23c
1 parent 9e1fc01
commit b54b23c
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/client/app/visualizations/counter/Renderer.jsx b/client/app/visualizations/counter/Renderer.jsx
@@ -30,14 +30,21 @@ export default function Renderer({ data, options, visualizationName }) {
 
   useEffect(() => {
     if (container) {
-      setScale(getCounterScale(container)); // initial update
       const unwatch = resizeObserver(container, () => {
         setScale(getCounterScale(container));
       });
       return unwatch;
     }
   }, [container, setScale]);
 
+  useEffect(() => {
+    if (container) {
+      // update scaling when options or data change (new formatting, values, etc.
+      // may change inner container dimensions which will not be tracked by `resizeObserver`);
+      setScale(getCounterScale(container));
+    }
+  }, [data, options, container, setScale]);
+
   const {
     showTrend, trendPositive,
     counterValue, counterValueTooltip,