ci(release): use client-id for the tap-token GitHub App#1285
Merged
Conversation
actions/create-github-app-token deprecated `app-id` in favor of `client-id`; switch the Homebrew tap-token step to the App's Client ID (RELEASE_BOT_CLIENT_ID) to clear the deprecation warning. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/create-github-app-tokendeprecated theapp-idinput in favor ofclient-id; the v0.2.6 release run surfaced this as a warning on the Bump Homebrew formula job.release.ymlto pass the GitHub App's Client ID via the newRELEASE_BOT_CLIENT_IDsecret, and update the neighboring comment to match.Scope and exclusions
bump-homebrewjob.RELEASE_BOT_CLIENT_IDsecret has already been provisioned by the maintainer.How to verify
bump-homebrewjob only fires on stable tag pushes togetprovenant/provenant), so the real signal is the next stable release: theapp-iddeprecation warning should be gone and the tap-token step should still mint a valid token.Follow-up work
aws/taptrust notices are runner-image noise, and the container-imageartifact-metadata/no artifacts foundwarning is a benign message from the latestattest-build-provenancewhen attesting an OCI image (the attestation itself succeeds).