Add additional type hints #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I request that you combine these into a single PR? Commit for each file is fine but PR per file is a bit much :). |
Of course. Just let me know how it work best for you. Most projects prefer smaller PRs because they are easier and faster to merge. |
2 tasks
bjoernricks
changed the title
avaris
requested changes
Jan 22, 2024
bjoernricks
force-pushed
the
contents-types
branch
from
8a7d2e3 to
3eeae5f
Compare
bjoernricks
force-pushed
the
contents-types
branch
from
3eeae5f to
d062a07
Compare
Types make it easier to understand the code and improve autocompletion in IDEs.
bjoernricks
force-pushed
the
contents-types
branch
from
d062a07 to
e9f684f
Compare
Types make it easier to understand the code and improve autocompletion in IDEs.
bjoernricks
force-pushed
the
contents-types
branch
from
e9f684f to
e480731
Compare
avaris
approved these changes
Jan 24, 2024
justinmayer
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Many thanks to @bjoernricks for the enhancement and to @avaris for reviewing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Adding the types spotted issues with the
Contents.source_pathattribute if it'sNone. For examplerelative_dirproperty will crash in that case.