-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tzdata
requirement on Windows
#3246
Conversation
I was confused a bit. I was going to say it should show up in tests but that's why tests were passing :). I think it should be removed from |
Should be installed by pelican directly, if needed, based on OS.
done! |
FYI, here's where
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for this snafu. When I first saw this error, I read something on the Internet that gave me the (clearly-mistaken) impression that the tzdata
dependency was something that only needed to be addressed when testing on Windows and that was not otherwise necessary to use Pelican on Windows. Mea culpa.
Many thanks to @MinchinWeb for the fix and to @avaris for reviewing.
No worries @justinmayer ! You and avaris do a great job of keeping the project moving forward, and make it easy to contribute, and this is still a timely fix. Mostly I just got a little chuckle that I wasn't able to help with your 3.9 release sprint, but instead found this the next day. |
Further to #3161,
tzdata
is required on Windows, even when using a version of Python that includeszoneinfo
in the standard library. This is because Windows doesn't ship with the "standard" timezone database; c.f. PEP 615.Without this, Pelican 4.9.0 will spit out a series of errors (one for each entry), like:
and then finally has a fatal error:
I also note that
tzdata
is listed as a requirement for testing; it may no longer be needed there.