Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreliable WRITE_SELECTED feature #3243

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Remove unreliable WRITE_SELECTED feature #3243

merged 1 commit into from
Nov 12, 2023

Conversation

avaris
Copy link
Member

@avaris avaris commented Nov 12, 2023

Implementation is buggy and unreliable. Therefore, it is better to remove the functionality until a robust implementation is added.

Pull Request Checklist

Resolves: #2678

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

@avaris
remove WRITE_SELECTED
86d6898 
Implementation is buggy and unreliable. Therefore, it is better to
remove the functionality until a robust implementation is added.
@avaris avaris requested a review from justinmayer November 12, 2023 16:48
@avaris avaris changed the title remove WRITE_SELECTED Eemove WRITE_SELECTED Nov 12, 2023
@avaris avaris changed the title Eemove WRITE_SELECTED Remove WRITE_SELECTED Nov 12, 2023
@justinmayer justinmayer changed the title Remove WRITE_SELECTED Remove unreliable WRITE_SELECTED feature Nov 12, 2023
justinmayer
justinmayer approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this, @avaris! 👏

@justinmayer justinmayer merged commit 9525583 into getpelican:master Nov 12, 2023
15 checks passed
@avaris avaris deleted the remove-write-selected branch November 12, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmayer justinmayer justinmayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it possible write-selected just doesn't work?
2 participants
@avaris @justinmayer