Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade code base for Python 3.8 and above #3241

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Upgrade code base for Python 3.8 and above #3241

merged 1 commit into from
Nov 12, 2023
+58 −64

Conversation

justinmayer
Copy link
Member

This upgrades the Pelican code base for Python 3.8 and above. Performed via:

pipx run pyupgrade --py38-plus pelican/**/*.py

@justinmayer
Update code base for Python 3.8 and above
ecd598f 
Result of: pipx run pyupgrade --py38-plus pelican/**/*.py
@justinmayer justinmayer requested a review from avaris November 12, 2023 12:57
pauloxnet
pauloxnet approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmayer
Copy link
Member Author

Follow-up question… Is this the kind of commit that should be added to .git-blame-ignore-revs? Or is there some reason to have these changes show up in git blame?

@pauloxnet
Copy link
Member

Follow-up question… Is this the kind of commit that should be added to .git-blame-ignore-revs? Or is there some reason to have these changes show up in git blame?

In other similar projects (e.g. Django) is common to ignore this type of commit.

avaris
avaris approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@avaris avaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I am fine with excluding this from blame.

@justinmayer
Copy link
Member Author

@pauloxnet & @avaris: Thanks for having a look!

@justinmayer justinmayer merged commit e92ccb8 into master Nov 12, 2023
30 checks passed
@justinmayer justinmayer deleted the pyupgrade-py38-plus branch November 12, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaris avaris avaris approved these changes

@pauloxnet pauloxnet pauloxnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinmayer @pauloxnet @avaris