-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support --exclude-from for rsync publishing using excludes.txt #2659
base: main
Are you sure you want to change the base?
Conversation
Add an excludes.txt example file where users can list rsync exclude specifications. If the site you are publishing has any paths on the remote site that Pelican should ignore and not remove, list them in excludes.txt so they are not removed each time you do: make rsync_upload The example file has a comment pointing users to the rsync man page for information on the format used in exclude files. The only entry in it by default is the .DS_Store entry which was from the rsync command in tasks.py.
Two comments:
|
Makes sense, I can change that.
Initially I didn't make it a jinja template, but I decided to follow what the other template files were doing. I don't know what jinja is anyway. I can just drop all that. Changes coming up. |
Give the rsync excludes file a bit more of a descriptive name.
…2659) No need to have this file be a template. It can just be written out as a string.
Hey David. I keep looking at this PR from time to time, and I guess my question is what is the impetus for storing the excludes outside Am I missing something? Is it just me? |
The main objective is to allow rsync exclude pattern syntax in the external excludes list and avoid string manipulation problems that may come about while writing an excludes list as a string in Python or in a Makefile or something like that. The other objective I had was to permit site-specific customization in a file not owned by the upstream project to allow for easier merging/rebasing of upstream code from Pelican to your own local project. |
Add an excludes.txt example file where users can list rsync exclude
specifications. If the site you are publishing has any paths on the
remote site that Pelican should ignore and not remove, list them in
excludes.txt so they are not removed each time you do:
The example file has a comment pointing users to the rsync man page
for information on the format used in exclude files. The only entry
in it by default is the .DS_Store entry which was from the rsync
command in tasks.py.