Replace asynctask uploader with viewmodel#7008
Merged
grzesiek2010 merged 44 commits intogetodk:masterfrom Apr 10, 2026
Merged
Conversation
seadowg
requested changes
Feb 26, 2026
grzesiek2010
force-pushed
the
COLLECT-6827
branch
2 times, most recently
from
0bc07f7 to
b2d5dac
Compare
seadowg
requested changes
Mar 10, 2026
Member
seadowg
left a comment
seadowg
left a comment
There was a problem hiding this comment.
Just posting another structural change I think would be good here!
grzesiek2010
force-pushed
the
COLLECT-6827
branch
from
f929674 to
8f5a292
Compare
seadowg
reviewed
Mar 17, 2026
grzesiek2010
force-pushed
the
COLLECT-6827
branch
from
912e28f to
6bf0b96
Compare
…f InstanceUploader directly
grzesiek2010
force-pushed
the
COLLECT-6827
branch
from
6bf0b96 to
f4e6264
Compare
seadowg
requested changes
Apr 3, 2026
Member
seadowg
left a comment
seadowg
left a comment
There was a problem hiding this comment.
Could you also update the STATE.md with decision around using coroutines in Kotlin code?
seadowg
approved these changes
Apr 10, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6827
Why is this the best possible solution? Were any other approaches considered?
The issue itself was not significant and could be fixed without major changes. However, it was based on a long-deprecated
AsyncTask, so it was a good opportunity to replace it with modern architecture components, which I did while also ensuring the issue was properly addressed.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We need to carefully test the entire process of manually uploading finalized forms (from the list of forms to send), as this functionality has been refactored.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest