Fixed clearing errors #6656
Open
Fixed clearing errors #6656
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
Mar 20, 2025
...t_app/src/androidTest/java/org/odk/collect/android/feature/formentry/RequiredQuestionTest.kt
Outdated
Show resolved
Hide resolved
| @@ -166,7 +167,9 @@ class WidgetAnswerText(context: Context, attrs: AttributeSet?) : FrameLayout(con | |||
| } | |||
|
|
|||
| fun setError(error: String?) { | |||
| binding.textInputLayout.error = error | |||
| binding.textInputLayout.post { | |||
There was a problem hiding this comment.
This new scenario needs some delay to clear the error after recreating the view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6508
Why is this the best possible solution? Were any other approaches considered?
It seems that Android might be retaining the error, possibly through the text field ID, and keeps it displayed after the view is recreated. To resolve this, we need to programmatically clear the error during the view creation process.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It should just fix the issue but please make sure errors are displayed and cleared correctly in text questions.
Do we need any specific form for testing your changes? If so, please attach one.
The form from the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest