-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up EntitiesRepository API #6614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
9083f65
to
489a513
Compare
This isn't really a concept we'd want to express through a query as it's a special case for entities.
d4cfaae
to
90d6607
Compare
grzesiek2010
approved these changes
Feb 27, 2025
Tested with Success! Verified on a device with Android 10 Verified cases:
|
Tested with success Verified on device with Android 15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6566
Blocked by #6601Blocked by #6619This updates the
delete
method as described in the issue, and also removes methods we're no longer using (likegetAllByProperty
).Why is this the best possible solution? Were any other approaches considered?
Not much to discuss here really! The only thing I'd point out is that I left in the (currently failing) tests for #6615 as that will make working on that issue easier when we get to it.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
There's some risk to follow up and update entity forms as this messes with some of the code we use for filtering.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest