Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up EntitiesRepository API #6614

Merged
merged 8 commits into from
Feb 27, 2025

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Feb 17, 2025

Closes #6566
Blocked by #6601
Blocked by #6619

This updates the delete method as described in the issue, and also removes methods we're no longer using (like getAllByProperty).

Why is this the best possible solution? Were any other approaches considered?

Not much to discuss here really! The only thing I'd point out is that I left in the (currently failing) tests for #6615 as that will make working on that issue easier when we get to it.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

There's some risk to follow up and update entity forms as this messes with some of the code we use for filtering.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg force-pushed the entities-repository branch 2 times, most recently from 9083f65 to 489a513 Compare February 25, 2025 14:26
@seadowg seadowg force-pushed the entities-repository branch from d4cfaae to 90d6607 Compare February 27, 2025 12:09
@seadowg seadowg removed the blocked label Feb 27, 2025
@seadowg seadowg marked this pull request as ready for review February 27, 2025 13:57
@seadowg seadowg requested a review from grzesiek2010 February 27, 2025 13:57
@grzesiek2010 grzesiek2010 merged commit 232cc9d into getodk:master Feb 27, 2025
6 checks passed
@seadowg seadowg deleted the entities-repository branch February 28, 2025 08:39
@dbemke
Copy link

dbemke commented Mar 3, 2025

Tested with Success!

Verified on a device with Android 10

Verified cases:

  • registration, update and follow up forms
  • deleting entities
  • new versions of forms. deleting blank forms and redownloading when entities are deleted
  • deleting entities when there's a draft and finalized version of an update forms
  • deleting entities, adding properties in forms with a dataset with special character
  • entities forms with filtering

@WKobus
Copy link

WKobus commented Mar 3, 2025

Tested with success

Verified on device with Android 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize EntitiesRepository#delete to accept list name for direct entity removal
4 participants