Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move entities package from JavaRosa #6236

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jun 27, 2024

Blocked by getodk/javarosa#772

This allows us to iterate on entities without as much back and forth between Collect and JavaRosa changes.

Why is this the best possible solution? Were any other approaches considered?

I could have converted more classes to Kotlin, but there's a lot of code here and I felt like that would easier to review on a case by case basis as we touch those classes.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

A lot of code has been moved, and a few things have been converted to Kotlin, so there's definitely a risk of type conversion problems. The most important things to look at will be form loading and finalization, especially for forms with entities.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@lognaturel lognaturel changed the title Move entites package to Collect Move entities package to Collect Jun 27, 2024
@lognaturel lognaturel changed the title Move entities package to Collect Move entities package from JavaRosa Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant