Move entities package from JavaRosa #6236
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by getodk/javarosa#772
This allows us to iterate on entities without as much back and forth between Collect and JavaRosa changes.
Why is this the best possible solution? Were any other approaches considered?
I could have converted more classes to Kotlin, but there's a lot of code here and I felt like that would easier to review on a case by case basis as we touch those classes.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
A lot of code has been moved, and a few things have been converted to Kotlin, so there's definitely a risk of type conversion problems. The most important things to look at will be form loading and finalization, especially for forms with entities.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest