blobs: prevent NULL contentType in db #1355
Open
+36
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 13, 2025 06:20
Set blob."contentType" values to application/octet-stream if no mime type is supplied on upload. Related: getodk#1351
alxndrsn
changed the title
alxndrsn
changed the title
alxndrsn
changed the title
ktuite
reviewed
Jan 13, 2025
Comment on lines
+10
to
+14
| const up = (db) => db.raw(` | ||
| ALTER TABLE blobs | ||
| ALTER COLUMN "contentType" SET NOT NULL, | ||
| ALTER COLUMN "contentType" SET DEFAULT 'application/octet-stream' | ||
| `); |
There was a problem hiding this comment.
When I run this (with null content type values in my DB) I get an error
migration file "20250113-01-disable-nullable-blob-content-types.js" failed
migration failed with error:
ALTER TABLE blobs
ALTER COLUMN "contentType" SET NOT NULL,
ALTER COLUMN "contentType" SET DEFAULT 'application/octet-stream'
- column "contentType" of relation "blobs" contains null values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
blob."contentType"values to application/octet-stream if no mime type is supplied on upload.Related: #1351
What has been done to verify that this works as intended?
CI.
Why is this the best possible solution? Were any other approaches considered?
Discussion on #1351.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This will change
Content-Typeheaders for files uploaded without one from the stringnullto the stringapplication/octet-stream.Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Yes.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes