lib/crypto: add special handling to help diagnose #1212 #1329

alxndrsn · 2024-12-05T09:54:14Z

Help diagnose #1212 by logging more details when the error occurs in CI.

alxndrsn · 2024-12-05T10:46:16Z

It looks like errors will bubble as required (https://app.circleci.com/pipelines/github/alxndrsn/odk-central-backend/2154/workflows/983ec96f-ce7f-48c5-bef3-4018454754a4/jobs/2082):

    end-to-end @slow
::ffff:127.0.0.1 - - [05/Dec/2024:09:56:27 +0000] "POST /v1/sessions HTTP/1.1" 200 228
::ffff:127.0.0.1 - - [05/Dec/2024:09:56:28 +0000] "POST /v1/projects/1/key HTTP/1.1" 200 16
::ffff:127.0.0.1 - - [05/Dec/2024:09:56:28 +0000] "GET /v1/projects/1/forms/simple.xml HTTP/1.1" 200 1285
::ffff:127.0.0.1 - - [05/Dec/2024:09:56:28 +0000] "POST /v1/projects/1/forms/simple/submissions HTTP/1.1" 200 322
::ffff:127.0.0.1 - - [05/Dec/2024:09:56:28 +0000] "POST /v1/projects/1/forms/simple/submissions/one/attachments/submission.xml.enc HTTP/1.1" 200 16
::ffff:127.0.0.1 - - [05/Dec/2024:09:56:28 +0000] "GET /v1/projects/1/forms/simple/submissions/keys HTTP/1.1" 200 492
Error: #1212 Error thrown for {"keys":{"iv":"x2v9ZJz14hJy4/G9ma0yAg==","salt":"oXL2+4aFtutlKoBwTBDa8w==","pubkey":"LS0tLS1CRUdJTiBQVUJMSUMgS0VZLS0tLS0KTUlJQklqQU5CZ2txaGtpRzl3MEJBUUVGQUFPQ0FROEFNSUlCQ2dLQ0FRRUFzL0ljdWlaMmpOSU9QK3J4cU1kaApjUzM4aUZwc1Q2ZVBYc2RPK1FHRTVVVGV2Zm9aZzdyS05zTCs4d2tBS2QyM0U2QlpBWWpLSWExdUU0ejlpT1UrCnRDRWJVZ0VFRmlZdkhCTmVJaVRaNnhHT0sybEZmeFVCQjVTUFhNQjQxUmo3ZVJ4WXFTU0FEWWhqQ29LcU1ycysKc241UExKT3M3UlNzd2I4L0pGQ1ZKMWRVNmVodmticXBPR0FoSmxITVhPZXJ5NUFVTGhSZy9IRmFUK3dUdFk4NgpvUjl2bHRJdVJNS2I3djZMdDg1UUhRY0wzTzZ1ZGRVcjVMVVpYd1pzdHozTjdWOHJtRTltcG1CUFRUeDYrTjhpCkhTRXBTRXh4T0g5ZXFNWHdZNlFTYWNBb3VhZHd2U05udm9SN1dWeXRIb3JSd2wrOUVzT3lmMUM4THdCeUc4RXEKWlFJREFRQUIKLS0tLS1FTkQgUFVCTElDIEtFWS0tLS0tCg==","privkey":"pZEStvnPZlx2YOitAa0U0Z49tbHx8D7h1rFOyizIVuNyTDb+LDUpGatB+60BphZJuR8Ne6lWBCPhvj2H8LNrWjB+xYRd6ouP6G7pCgK72lluATYUFce/pla+PoMucHXUnIjMadH3lu8t5i/nlc1LnEd4xOdErGZFjggv4bFqF50zfPA1gf2yXZHUi4JzMtAH6Cpuu0uJvVqYGW4w74b1j7ZqCW2o11dpDoKsfwJnvHL976nwWujyap37tlZEpCCFKbjq5/qUn8o2niDagzMqE63tP+L5mztLl/q7mZMqXjx5xj/jsBO/lrpOOkqGZWpORvZwu4zIkr4VN0ZR7KqpFi5eVubqalX2tY0u76egJYKb87Fe7XjA+XhrsBOUBzJKLNQDyLtdT4j+3FI3mG19pzpwOEu/+EOifXK3uCi/chYzdLimKaZFuM5G82814w5tIZSa5xID1QWyHN8pLOmMshZV9PKYvABlfvZFJK/1KtPWqjGqgcRrZogWI2Ex9t1230owzBsmEprlUBgtquOruK/DGfCQ+7O+KFURMt25eOQrmi/6XJKjdXUL2eWulLGjtNaBBpmw8EC/64hA+HqDKuS0sBU+TMBlyA6ekhH8GUvsZi8hEIN8zq4n5OvOMIR0smgtt9EzXCAsjS1ylaCtpGGsAvW8ePOWINafgZ/CS2akgJRWTbzJYK5VwovB1UG+lqX5B4FFfDp5+wb3DUn0SRSVpuXwr3+NCTLsXsRImQJKGOigVJasMrzn9K1qrqGVrRLFGiqIUQZxvnMLKXqCi/Hl7U/PPyJ7PndsRZamOCDDxLpBAh+2nCmyayDUObWnCKN0KWOXonqWKQy/uUGcxxEsREXShrGQuYMlvo9gM8t0p+xAnW8GBTHPsFnI9KL1/3c4uCjErUSDMakgf+sJGsO8HlxGh5c27tqz2jswHsEEsrG4Y7AEktMnJuDqF4N2IGT0s0luwdd7fN0GxEiHwGAgtPM0E48I/W9T7QaQQvuo7T2gUqAv8/W+516NeRP9h4KaV98WO3COCJubj4hldhG7cAVd2yJrWGETuvRYknP54DgWkLbm1EeWqCA1i9U675ubJonrXKVjqNxICNFDRhOeoJduTK15puZCdMmjLuEtAOymoTeeJOI52R+I7BbMojepiX4EZVuuxAk3ksMkuddCiHSEJ+B/5nuLlZcBsFnuNMxltPHW5BPP9Fj3GHrNjmql1Jqksw2yxwE6HT4iVkP2ZwcI7xoDLbNk7cBHo4XCvU/TRGXGUvLrpWIaC1fg7AiZw+d1kNjrY7VsbHPs9P11jVNSQ0cwl0FBa9yl9jTuvl52skp7LEEczLjDQcpNwoKyhh+MnGACaT191Be2MBb9NRH0dQ0zqZHzYT0bZZ7D5I+yWQve7UIfiFNDUNPnXWC8nopKkgvWYMuyNzyrU+O+XBmcYff+79XuJUQ2ZA2nz81frb52Yp/U3BZF96XzlYMVPeHVDc8/2oVip1k3l67nVee4cqro9ma8BB+DYE1nje3yB2POPJ569bG3LHNt5H73pcEYvXHDPjgHnEcAylYtJrUyqjmyYgv6mz+MCvIR8dXWnLkL+GbZFOb1i2H8U9vdlXzU3o/lz8h6hpGyOMJEaZxq2w3l0FImHGuLOTgdYWM7zgNTpdh5nszGO15Sk3JcPLLfvF4MTXUXvfP9k5xHh9EqBF5kzb05YmdgQt8KZ0ryn+2oYvN/rizqK4yLb9YcXccOk5gBxp2CKG3HW8zcYwOKS96c+yLPdMT9yBdFxyC5QFgp3diNaPSnfdq44AdfFT4cGBKDF8OedDOT0iXDLXGjjNzisOruaxNuVteqjtxvUdm37da6JjohUVUb54lpnLJyNLfYtALism4UZMnQukmNXIfesJRrZ9Jkc5raxPK8HyLZ8PXcRMo0lVOrfuQwuUPrSvCGB/zxh0q+Sjkk4Xm21mrTdUW4F/Ej1Nr6xl4W9e2wfb7jlD/NewIJrAHYkZoK4T+CoGHdA8p5JR0Zg7ejbU+PZO8M1PwuoxVBm3yE+d66IBFVigpO52628PdDrGBvQap+T6L/NUSqX0EaO0bfItpiRcGLfvJQeJD/w9EXhoPDEeQZeeDguSScwozDTVOeMsJo9MXAWezpVor9W0y3yDqCUN4NmsjU8lmCm/WQC4IK1AXIDept4blOnos3EH/Lrp/55vwxNGMWBBDegU2r3e8WU4IlNSbT65tWUVQJtjuNEKA/TA3eJ+0a033awGNLov37yUKz0+hmzZXndDcX5AFPBzABuanmIvQ="},"passphrase":"wrong"}
          This error is thrown for debugging https://github.com/getodk/central-backend/issues/1212.
          NOTE this is logging secret material so MUST NOT run outside of test environments.
        
    at /home/circleci/repo/lib/util/crypto.js:161:15
    at async Promise.all (index 0) {
  [cause]: Error: error:1C800064:Provider routines::bad decrypt
      at Decipheriv.final (node:internal/crypto/cipher:193:29)
      at /home/circleci/repo/lib/util/crypto.js:157:93
      at async Promise.all (index 0) {
    library: 'Provider routines',
    reason: 'bad decrypt',
    code: 'ERR_OSSL_BAD_DECRYPT'
  }
}Error: #1212 Error thrown for {"keys":{"iv":"x2v9ZJz14hJy4/G9ma0yAg==","salt":"oXL2+4aFtutlKoBwTBDa8w==","pubkey":"LS0tLS1CRUdJTiBQVUJMSUMgS0VZLS0tLS0KTUlJQklqQU5CZ2txaGtpRzl3MEJBUUVGQUFPQ0FROEFNSUlCQ2dLQ0FRRUFzL0ljdWlaMmpOSU9QK3J4cU1kaApjUzM4aUZwc1Q2ZVBYc2RPK1FHRTVVVGV2Zm9aZzdyS05zTCs4d2tBS2QyM0U2QlpBWWpLSWExdUU0ejlpT1UrCnRDRWJVZ0VFRmlZdkhCTmVJaVRaNnhHT0sybEZmeFVCQjVTUFhNQjQxUmo3ZVJ4WXFTU0FEWWhqQ29LcU1ycysKc241UExKT3M3UlNzd2I4L0pGQ1ZKMWRVNmVodmticXBPR0FoSmxITVhPZXJ5NUFVTGhSZy9IRmFUK3dUdFk4NgpvUjl2bHRJdVJNS2I3djZMdDg1UUhRY0wzTzZ1ZGRVcjVMVVpYd1pzdHozTjdWOHJtRTltcG1CUFRUeDYrTjhpCkhTRXBTRXh4T0g5ZXFNWHdZNlFTYWNBb3VhZHd2U05udm9SN1dWeXRIb3JSd2wrOUVzT3lmMUM4THdCeUc4RXEKWlFJREFRQUIKLS0tLS1FTkQgUFVCTElDIEtFWS0tLS0tCg==","privkey":"pZEStvnPZlx2YOitAa0U0Z49tbHx8D7h1rFOyizIVuNyTDb+LDUpGatB+60BphZJuR8Ne6lWBCPhvj2H8LNrWjB+xYRd6ouP6G7pCgK72lluATYUFce/pla+PoMucHXUnIjMadH3lu8t5i/nlc1LnEd4xOdErGZFjggv4bFqF50zfPA1gf2yXZHUi4JzMtAH6Cpuu0uJvVqYGW4w74b1j7ZqCW2o11dpDoKsfwJnvHL976nwWujyap37tlZEpCCFKbjq5/qUn8o2niDagzMqE63tP+L5mztLl/q7mZMqXjx5xj/jsBO/lrpOOkqGZWpORvZwu4zIkr4VN0ZR7KqpFi5eVubqalX2tY0u76egJYKb87Fe7XjA+XhrsBOUBzJKLNQDyLtdT4j+3FI3mG19pzpwOEu/+EOifXK3uCi/chYzdLimKaZFuM5G82814w5tIZSa5xID1QWyHN8pLOmMshZV9PKYvABlfvZFJK/1KtPWqjGqgcRrZogWI2Ex9t1230owzBsmEprlUBgtquOruK/DGfCQ+7O+KFURMt25eOQrmi/6XJKjdXUL2eWulLGjtNaBBpmw8EC/64hA+HqDKuS0sBU+TMBlyA6ekhH8GUvsZi8hEIN8zq4n5OvOMIR0smgtt9EzXCAsjS1ylaCtpGGsAvW8ePOWINafgZ/CS2akgJRWTbzJYK5VwovB1UG+lqX5B4FFfDp5+wb3DUn0SRSVpuXwr3+NCTLsXsRImQJKGOigVJasMrzn9K1qrqGVrRLFGiqIUQZxvnMLKXqCi/Hl7U/PPyJ7PndsRZamOCDDxLpBAh+2nCmyayDUObWnCKN0KWOXonqWKQy/uUGcxxEsREXShrGQuYMlvo9gM8t0p+xAnW8GBTHPsFnI9KL1/3c4uCjErUSDMakgf+sJGsO8HlxGh5c27tqz2jswHsEEsrG4Y7AEktMnJuDqF4N2IGT0s0luwdd7fN0GxEiHwGAgtPM0E48I/W9T7QaQQvuo7T2gUqAv8/W+516NeRP9h4KaV98WO3COCJubj4hldhG7cAVd2yJrWGETuvRYknP54DgWkLbm1EeWqCA1i9U675ubJonrXKVjqNxICNFDRhOeoJduTK15puZCdMmjLuEtAOymoTeeJOI52R+I7BbMojepiX4EZVuuxAk3ksMkuddCiHSEJ+B/5nuLlZcBsFnuNMxltPHW5BPP9Fj3GHrNjmql1Jqksw2yxwE6HT4iVkP2ZwcI7xoDLbNk7cBHo4XCvU/TRGXGUvLrpWIaC1fg7AiZw+d1kNjrY7VsbHPs9P11jVNSQ0cwl0FBa9yl9jTuvl52skp7LEEczLjDQcpNwoKyhh+MnGACaT191Be2MBb9NRH0dQ0zqZHzYT0bZZ7D5I+yWQve7UIfiFNDUNPnXWC8nopKkgvWYMuyNzyrU+O+XBmcYff+79XuJUQ2ZA2nz81frb52Yp/U3BZF96XzlYMVPeHVDc8/2oVip1k3l67nVee4cqro9ma8BB+DYE1nje3yB2POPJ569bG3LHNt5H73pcEYvXHDPjgHnEcAylYtJrUyqjmyYgv6mz+MCvIR8dXWnLkL+GbZFOb1i2H8U9vdlXzU3o/lz8h6hpGyOMJEaZxq2w3l0FImHGuLOTgdYWM7zgNTpdh5nszGO15Sk3JcPLLfvF4MTXUXvfP9k5xHh9EqBF5kzb05YmdgQt8KZ0ryn+2oYvN/rizqK4yLb9YcXccOk5gBxp2CKG3HW8zcYwOKS96c+yLPdMT9yBdFxyC5QFgp3diNaPSnfdq44AdfFT4cGBKDF8OedDOT0iXDLXGjjNzisOruaxNuVteqjtxvUdm37da6JjohUVUb54lpnLJyNLfYtALism4UZMnQukmNXIfesJRrZ9Jkc5raxPK8HyLZ8PXcRMo0lVOrfuQwuUPrSvCGB/zxh0q+Sjkk4Xm21mrTdUW4F/Ej1Nr6xl4W9e2wfb7jlD/NewIJrAHYkZoK4T+CoGHdA8p5JR0Zg7ejbU+PZO8M1PwuoxVBm3yE+d66IBFVigpO52628PdDrGBvQap+T6L/NUSqX0EaO0bfItpiRcGLfvJQeJD/w9EXhoPDEeQZeeDguSScwozDTVOeMsJo9MXAWezpVor9W0y3yDqCUN4NmsjU8lmCm/WQC4IK1AXIDept4blOnos3EH/Lrp/55vwxNGMWBBDegU2r3e8WU4IlNSbT65tWUVQJtjuNEKA/TA3eJ+0a033awGNLov37yUKz0+hmzZXndDcX5AFPBzABuanmIvQ="},"passphrase":"wrong"}
          This error is thrown for debugging https://github.com/getodk/central-backend/issues/1212.
          NOTE this is logging secret material so MUST NOT run outside of test environments.
        
    at /home/circleci/repo/lib/util/crypto.js:161:15
    at async Promise.all (index 0) {
  [cause]: Error: error:1C800064:Provider routines::bad decrypt
      at Decipheriv.final (node:internal/crypto/cipher:193:29)
      at /home/circleci/repo/lib/util/crypto.js:157:93
      at async Promise.all (index 0) {
    library: 'Provider routines',
    reason: 'bad decrypt',
    code: 'ERR_OSSL_BAD_DECRYPT'
  }
}::ffff:127.0.0.1 - - [05/Dec/2024:09:56:28 +0000] "GET /v1/projects/1/forms/simple/submissions.csv.zip?4=wrong HTTP/1.1" 500 35
      1) should reject with a reasonable message given incorrect passphrase

This test case has now been fixed.

alxndrsn · 2025-01-09T16:53:49Z

lib/util/crypto.js

+          This error is thrown for debugging https://github.com/getodk/central-backend/issues/1212.
+          NOTE this is logging secret material so MUST NOT run outside of test environments.
+        `, { cause: ex });
+      }


Add an extra comment requesting any info logged gets added to the github issue.

alxndrsn added 2 commits December 5, 2024 09:53

lib/crypto: add special handling to help diagnose getodk#1212

246d01e

lint

45f10f6

alxndrsn added 2 commits December 5, 2024 10:49

ignore deliberate errors

5fedb88

Merge branch 'master' into 1212-logging

666b2c8

matthew-white self-requested a review January 9, 2025 16:53

alxndrsn commented Jan 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib/crypto: add special handling to help diagnose #1212 #1329

lib/crypto: add special handling to help diagnose #1212 #1329

alxndrsn commented Dec 5, 2024

alxndrsn commented Dec 5, 2024 •

edited

Loading

alxndrsn Jan 9, 2025

lib/crypto: add special handling to help diagnose #1212 #1329

Are you sure you want to change the base?

lib/crypto: add special handling to help diagnose #1212 #1329

Conversation

alxndrsn commented Dec 5, 2024

alxndrsn commented Dec 5, 2024 • edited Loading

alxndrsn Jan 9, 2025

Choose a reason for hiding this comment

alxndrsn commented Dec 5, 2024 •

edited

Loading