Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Catalog] - Portfolio Access, Portfolio Share, and Portfolio Work #8657

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Singha22
Copy link
Contributor

@Singha22 Singha22 commented Mar 6, 2025

Resolves #8692

@Singha22 Singha22 changed the title Service Catalog [Service Catalog] - list_portfolio_access, delete_portfolio, delete_portfolio_share, create_portfolio, create_portfolio_share, list_portfolios Mar 17, 2025
@Singha22 Singha22 changed the title [Service Catalog] - list_portfolio_access, delete_portfolio, delete_portfolio_share, create_portfolio, create_portfolio_share, list_portfolios [Service Catalog] - Portfolio Access, Portfolio Share, and Portfolio Work Mar 17, 2025
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 96.96970% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.77%. Comparing base (415360d) to head (dab8f5b).

Files with missing lines Patch % Lines
moto/servicecatalog/models.py 94.91% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8657    +/-   ##
========================================
  Coverage   92.76%   92.77%            
========================================
  Files        1252     1256     +4     
  Lines      108766   108964   +198     
========================================
+ Hits       100896   101088   +192     
- Misses       7870     7876     +6     
Flag Coverage Δ
servertests 28.26% <0.00%> (-0.11%) ⬇️
unittests 92.74% <96.96%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Singha22 Singha22 marked this pull request as ready for review March 20, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Service Catalog] New Service Creation
1 participant