Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apigateway Account APIs #8119

Merged
merged 6 commits into from
Sep 14, 2024

Conversation

mattheidelbaugh
Copy link
Contributor

@mattheidelbaugh mattheidelbaugh commented Sep 11, 2024

  • Implement get_account and update_account for apigateway
  • Added rootResourceId to the RestAPI class and its to_dict function so that it will be returned as it was missing (create_rest_api, get_rest_api)

@mattheidelbaugh
Copy link
Contributor Author

mattheidelbaugh commented Sep 11, 2024

note/question:

  • It seems as though for some reason we don't get the boto validation for patchOperations. Validation for this seems to be at best partially implemented for other resources, so I did similarly here. Can certainly add that if desired.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (255d2b8) to head (da751c5).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8119      +/-   ##
==========================================
+ Coverage   94.46%   94.47%   +0.01%     
==========================================
  Files        1141     1141              
  Lines       98201    98352     +151     
==========================================
+ Hits        92761    92920     +159     
+ Misses       5440     5432       -8     
Flag Coverage Δ
servertests 28.95% <38.46%> (-0.01%) ⬇️
unittests 94.44% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zkarpinski zkarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @mattheidelbaugh!

@bblommers bblommers added this to the 5.0.15 milestone Sep 14, 2024
@bblommers bblommers merged commit c636d01 into getmoto:master Sep 14, 2024
51 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants